Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PowerMetric benchmark to measure Light vs Dark theme #827

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

yenerm
Copy link

@yenerm yenerm commented Jun 29, 2023

Adds PowerMetric benchmark which scrolls through the topics list in Light vs Dark theme

Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is relevant but the way the app looks is defined by:

  • the brand which the user chooses, this can be default or Android green
  • if the default brand is chosen then this will be pink on API < 31 or will use dynamic color on API 31+ if the user has selected that option
  • lastly, once the brand has been chosen, dark mode determines the actual colours used.

I'm guessing you just want to test light vs dark mode energy consumption but there might be some variance with the brand configurations as well.

@yenerm
Copy link
Author

yenerm commented Jul 13, 2023

Thanks Don! I addressed the comments. Also good points on variance with the brand configurations. I think the benchmark still makes sense as a sample in NiA.
Eventually (no the first priority) I am planning to add similar sample to performance samples but it doesn't currently have a theme for dark mode. Let me know wdyt?

@yenerm yenerm requested a review from dturner July 13, 2023 21:36
@dturner
Copy link
Collaborator

dturner commented Jul 21, 2023

Totally fine for this to be in this project. Implementing the theme wasn't trivial so probably makes sense to benchmark it here, rather than introducing that complexity into a simpler sample just to test it.

@yenerm yenerm merged commit 0c542b4 into main Jul 21, 2023
5 checks passed
@keyboardsurfer keyboardsurfer deleted the power-metric-benchmark branch September 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants